Solder alarmist post...
OK, I won't go too too deep into this...
Pb is ductile, High Sn Pb-free, less so...
I'm not certain just how much pressure / expansion force a tank seam itself may come under, but if the joint is flexing under thermal cycle (hot, cold, hot, cold)... Then SnPb often remains a preferred solution.
However, yes, Lead Free solders ARE "stronger" when testing initial shear force (lateral).
Honestly, I'd have to think either would work and that simply the wetting quality between the two interfaces plays a greater role.
Had my expansion tank, heater core, cross over fuel pipes and tanks tested and sealed. We'll see... I have my doubts. The heater core definitely was pressurized / expanded and 'carmelized' for my enjoyment.
Good luck,
Derek